Collection of Improvements#24
Conversation
There was a problem hiding this comment.
can you make use of versions.sh in this file to not repeat the version numbers?
There was a problem hiding this comment.
Unfortunately no, I think. This file belongs to the devcontainer s-core-devcontainer itself, not to the local feature s-core-local (which provides tools for which no existing devcontainer feature can be used). It would be an encapsulation violation to do so.
There was a problem hiding this comment.
It does sound wrong to have versions in two places. But I don't understand enough of the setup to propose any solution here.
Also the versions should be easily accessible somehow for unrelated, non-devcontainer usecases. That's probably a topic in itself.
duplicate, and it is already in the base-image anyway
otherwise, re-builds of the container may "suddenly" contain unexpected versions of relevant tools
this is really *a lot*
otherwise, re-builds of the container may "suddenly" contain unexpected versions of relevant tools
Since these tools are really important, we should definitely check that the versions are as expected.
Following https://code.visualstudio.com/remote/advancedcontainers/persist-bash-history, this implements an across-container-restarts-persistent bash history.
opajonk
force-pushed
the
collection-of-improvements
branch
from
8b55ce5 to
c0ac659
Compare
|
Getting |
| sudo chown "${USERNAME}:${GROUPNAME}" "${COMMANDHISTORY_DIR}" | ||
| sudo chmod 755 "${COMMANDHISTORY_DIR}" | ||
|
|
||
| # Create .bash_history file if it doesn't exist and set permissions |
There was a problem hiding this comment.
There was a problem hiding this comment.
Let me test that one. It has zsh support, which may be not a bad idea.
There was a problem hiding this comment.
I tried it, but it fails to install
0.109 ===========================================================================
0.110 Activating feature 'shell-history'
0.110 User: vscode User home:
0.110 ***********************************************************************************
0.110 *** Require _REMOTE_USER and _REMOTE_USER_HOME to be set (by dev container CLI) ***
0.110 ***********************************************************************************
0.110 ERROR: Feature "Shell History" (ghcr.io/stuartleeks/dev-container-features/shell-history) failed to install!
Apparently, there are additional requirements for this feature. For this little advantage, it seems to be too complicated.
opajonk
force-pushed
the
collection-of-improvements
branch
from
d4fe1db to
6e28bbb
Compare
3 participants
Here, I have collected a few improvements to the DevContainer which I think should go in before we call this a 1.0.0.